DA Floodgate Copy UI #3395
DA Floodgate Copy UI #3395
Conversation
<!-- Before submitting, please review all open PRs. --> * UI for the copy option Resolves: [MWPW-161908](https://jira.corp.adobe.com/browse/MWPW-161908)
There was a problem hiding this comment.
@colloyd Few observations:
-
There might be a need to provide some sort of message that the user has to click 'Copy' button after the 'Find' step is completed. It will not be intuitive for a new user that the button context has changed and they have to click the button again. Alternatively, a 'Continue' or 'Start Copy' button in the 'Find' tab-step view might help as well.
-
Making the text area uneditable after the process starts will be better as the list is technically locked in place unless they refresh the page. As the process pauses after 'Find' step and they have to click 'Copy' again, having a editable text-area gives the notion that it can be further updated.
-
In the 'Find' tab-step, it shows 'Pages' and 'Fragments' card. It will be good to rename 'Fragments' to 'Fragments and Assets' to avoid any confusion as the list/count includes both.
Thoughts?
|
@sukamat, we can certainly move the button for copy into the tab. I thought I'd give a stab at trying to cut down on the number of buttons on screen at once. I added the "Finding..." text to the button while it's finding fragments, so there's some precedent for the text changing. I figured we'd see what users thought of this and if it's not clear, we would refine from there. |
|
@sukamat Check it now. I disabled the text field when the user starts and I added messaging below the heading inside of the Find tab to indicate that they should press Copy to continue (after the find process is complete). |
There was a problem hiding this comment.
the & would be problematic as the name is converted as part of a classname elsewhere. My suggestion, given the details I mentioned in my slack to you would be to have a separate card for fragments and one for assets we would then need to setup the url object to include whether it was a fragment or an asset in addition to the other details I mentioned.
The classname conversion code in renderBadge() can be updated to exclude & with a simple regex change, right? Currently it seems to only handle names with space. Is there more to it than the regex change?
From what I see, separating fragments and assets in the response object and then handling them separately will be lot more work without any specific benefits.
Done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## floodbox #3395 +/- ##
===========================================
Coverage ? 98.84%
===========================================
Files ? 70
Lines ? 8660
Branches ? 0
===========================================
Hits ? 8560
Misses ? 100
Partials ? 0 ☔ View full report in Codecov by Sentry. |
* Floodbox - Floodgate and Graybox app * default path updated * option to set promote ignore paths * ignore files from promote * Added tree crawler with graybox exp path support * Intelligent org, repo, exp detection and validation * Promote graybox at path and folder level * Promote graybox files and folders with paths input * UI updates to show crawl, promote and preview flow * doc update * Floodgate copy updates * graybox refactor * unit tests for utils * lint fixes * MWPW-161576: Path validation before GB promote (#3217) * MWPW-161576: Path validation before GB promote * Fixed lint issues * unit tests added * remove unused var * graybox ui initial polish (#3223) <!-- Before submitting, please review all open PRs. --> * misc ui polishing Resolves: [MWPW-161925](https://jira.corp.adobe.com/browse/MWPW-161925) * Floodgate and Graybox app icons updated * MWPW-161929: Central configuration support for Graybox on DA (#3231) * Added Graybox Config support * Post merge fixes * refactor and made function private * handles promote ignore on paths and folders * added unit tests * remove empty paths * MWPW-161575: Floodgate app on DA - initial draft (#3240) * floodgate promote first draft * lint fix * fixed quotes * MWPW-161911: DA FG App Configuration (#3249) * Floodgate config to drive promote rules * unit tests added * temp change revert * Handles promote on drafts path only (#3262) Handle promote on drafts path only * DA Graybox UI (#3266) * DA Graybox UI <!-- Before submitting, please review all open PRs. --> * Tab UI for each step to promote * Detail cards for each step * Cleaned up the existing UI buttons and options Resolves: [MWPW-161925](https://jira.corp.adobe.com/browse/MWPW-161925) * removed placeholder paths * MWPW-161576: DA Floodbox UTs (#3291) * Unit tests for DA Floodbox * request handler changes * refactor updates * eslint fixes * eslint fixes * MWPW-161937: Handles images during promote (#3293) * MWPW-163511: DA Floodgate Copy Action (#3298) * MWPW-163511: DA Floodgate Copy * Updated unit tests * MWPW-161575: Unit tests for FG and GB (#3307) * MWPW-161575: Fragments and Asset extraction (#3316) - Limited to /fragments/ path and to pdf, svg and json references only * MWPW-163865: Ribbon UI for DA Graybox (#3340) * MWPW-163865: Ribbon UI for DA Graybox * eslint fix * DA graybox UI finalized (#3342) DA Graybox UI - Finalized <!-- Before submitting, please review all open PRs. --> * URL lists for ignore and errors * App reset when done * Refactor for reuse in floodgate Resolves: [MWPW-163768](https://jira.corp.adobe.com/browse/MWPW-163768) * DA Graybox UI Bug Fixes (#3352) <!-- Before submitting, please review all open PRs. --> * fix for reset tokens * fix for promote count with errors Resolves: [MWPW-164020](https://jira.corp.adobe.com/browse/MWPW-164020) Resolves: [MWPW-163995](https://jira.corp.adobe.com/browse/MWPW-163995) * MWPW-161575: Path validation fix (#3373) * MWPW-161575: Path validation fix * markup update * DA Floodgate Promote UI (#3378) <!-- Before submitting, please review all open PRs. --> * UI for the promote option Resolves: [MWPW-161908](https://jira.corp.adobe.com/browse/MWPW-161908) * DA Floodgate Copy UI (#3395) * DA Floodgate Copy UI <!-- Before submitting, please review all open PRs. --> * UI for the copy option Resolves: [MWPW-161908](https://jira.corp.adobe.com/browse/MWPW-161908) * fix for copy error list color * pr feedback * more pr feedback about fragments and assets * MWPW-164330: Delete Option in DA FG App (#3399) * MWPW-164330: Delete Option in DA FG * reset repo ready flag * repo data move * confirmation dialog * minor change * error card css update * renders error list for unpublish and delete * MWPW-161575: Unit tests added for DA FB (#3405) * bulk action unit tests * promote class unit tests * fg utils unit tests updated * MWPW-161920: Authenticated site support for preview (#3446) * MWPW-161920: Authenticated site support for preview - For preview/publish Helix API call, the auth token is passed in as the site is behind auth - mp4 reference check added * removed mp4 check * Removing the apps from config.json This needs to be added in the consumer DA repos when needed. Removing it from Milo repo to avoid conflicts. --------- Co-authored-by: Cody Lloyd <119891065+colloyd@users.noreply.github.com>
Resolves: MWPW-161908
Test URLs: